Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XML header and line breaks in SVG files. #5423

Merged
merged 1 commit into from
Jun 17, 2017

Conversation

pixelipo
Copy link
Contributor

My suggestion for further SVG optimiztion - as mentioned in #5229

Signed-off-by: Marin Treselj marin@pixelipo.com

My suggestion for further SVG optimiztion - as mentioned in #5229

Signed-off-by: Marin Treselj <marin@pixelipo.com>
@pixelipo pixelipo added 3. to review Waiting for reviews design Design, UI, UX, etc. labels Jun 15, 2017
@pixelipo pixelipo changed the title Remove XML heared and line breaks in SVG files. Remove XML header and line breaks in SVG files. Jun 15, 2017
@jancborchardt
Copy link
Member

Looks good! :) cc @nextcloud/designers for review.

@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Jun 17, 2017
@MorrisJobke MorrisJobke merged commit 38cf9b8 into master Jun 17, 2017
@MorrisJobke MorrisJobke deleted the better-svg-optimization branch June 17, 2017 23:35
@skjnldsv
Copy link
Member

Could be great to reoptimize all of them now that this is implemented! :)
Nice addition @pixelipo 👍

@jancborchardt
Copy link
Member

@skjnldsv before we do that we should revert the SVGO optimization though since it broke lots of icons ;) #4076 – then afterwards we can compress with Scour.

@pixelipo pixelipo mentioned this pull request Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants