Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix jquery-ui theming #8022

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Conversation

juliushaertl
Copy link
Member

Since we didn't backported #6341 to 12 this is a hotfix so we still have a themed upload progress, themed ldap wizard and any other jquery ui elements.

Would be great if you could test as well @realies

@nextcloud/theming

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@realies
Copy link

realies commented Jan 24, 2018

Thanks for the prompt pull request. This does fix the upload progress bar background when using different than the default theming colour.

before:
screen shot 2018-01-24 at 14 04 39

after:
screen shot 2018-01-24 at 15 11 32

Would it be relevant to have file rows highlighting be similar to the custom theming colour? Perhaps the theming colour with 0.5 opacity? An example when dragging files over to the same instance:
image

@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #8022 into stable12 will increase coverage by 0.29%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #8022      +/-   ##
==============================================
+ Coverage       53.84%   54.13%   +0.29%     
- Complexity      22758    22760       +2     
==============================================
  Files            1385     1377       -8     
  Lines           87148    86670     -478     
  Branches         1331     1331              
==============================================
- Hits            46925    46921       -4     
+ Misses          40223    39749     -474
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/appinfo/routes.php
...sharing/lib/Controller/PublicPreviewController.php
core/Command/Encryption/ListModules.php
.../lib/CalDAV/Search/Xml/Filter/SearchTermFilter.php
apps/files_sharing/list.php
apps/dav/lib/CalDAV/Activity/Provider/Calendar.php
apps/dav/bin/chunkperf.php
lib/private/URLGenerator.php
lib/private/Files/Node/LazyRoot.php
...ps/user_ldap/templates/part.wizard-groupfilter.php
... and 2752 more

@juliushaertl
Copy link
Member Author

Would it be relevant to have file rows highlighting be similar to the custom theming colour? Perhaps the theming colour with 0.5 opacity? An example when dragging files over to the same instance:

That is probably more something for a new issue, since it is more an enhancement of theming than a bugfix. 😉 Can you open a separate issue for that?

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

Thanks for the prompt pull request. This does fix the upload progress bar background when using different than the default theming colour.

Counting as second review -> merging

@MorrisJobke MorrisJobke merged commit 59a8cd3 into stable12 Jan 24, 2018
@MorrisJobke MorrisJobke deleted the fix-jquery-ui-theming branch January 24, 2018 14:41
@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants