Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cachebusters #934

Merged
merged 7 commits into from
Aug 18, 2016
Merged

Add cachebusters #934

merged 7 commits into from
Aug 18, 2016

Conversation

LukasReschke
Copy link
Member

Fixes #81

@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Aug 18, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Aug 18, 2016
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @Henni and @MorrisJobke to be potential reviewers

@@ -860,7 +860,7 @@ span.ui-icon {float: left; margin: 3px 7px 30px 0;}
div.crumb {
float: left;
display: block;
background-image: url('../img/breadcrumb.svg');
background-image: url('../img/breadcrumb.svg?v=1');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩

@nickvergessen
Copy link
Member

👍

@rullzer
Copy link
Member

rullzer commented Aug 18, 2016

damn that is ugly.... 🙊

@blizzz
Copy link
Member

blizzz commented Aug 18, 2016

To be increased every release?

@LukasReschke
Copy link
Member Author

To be increased every release?

If the linked resource changes, we have this already in place for a few other CSS files. But those were missing.

@blizzz
Copy link
Member

blizzz commented Aug 18, 2016

:shipit:

@blizzz blizzz merged commit 3b6bbf8 into master Aug 18, 2016
@blizzz blizzz deleted the add-cachebusters branch August 18, 2016 13:45
@MorrisJobke
Copy link
Member

@nextcloud/designers @Bugsbane Just to let you know of this: When changing an image/icon/... check if there is a reference right inside the CSS and adjust the number. This then allows us to provide the cache buster to hit in and always the correct image is used ;)

@jancborchardt
Copy link
Member

Alright, sounds good! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants