Remove internal tag routes

[rullzer]

As far as I can tell this is not used at all by any of our internal stuff. It is basically the predecesor of the systemtags as I understand it but is never used.

Any objections? @MorrisJobke @nickvergessen @icewind1991 @schiessle @blizzz @LukasReschke

[mention-bot]

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @tanghus, @nickvergessen and @MorrisJobke to be potential reviewers

[rullzer]

If it is used we should move it to a real (tested) controller. But I could find no such things.

[nickvergessen]

Those are the favorite icon tags?

[rullzer]

No that is done via a route in the files app

[nickvergessen]

No, those are the routes, to manually control those tags (like file favorites). It maybe that we don't use them, but any app could use those personal tags. So not sure if we should delete it.

I'd vote for moving to a normal controller.

[rullzer]

I'd vote for moving to a normal controller.

Fair enough. Should not be to hard.

On a side note we need to think how we define 'internal' routes. So stuff that might change at any given time.

[nickvergessen]

On a side note we need to think how we define 'internal' routes. So stuff that might change at any given time.

Anything that is not OCS is internal as far as i know 😉

[rullzer]

Well then other apps should not use it as well ;)

[MorrisJobke]

Well then other apps should not use it as well ;)

Correct.

[rullzer]

I moved it over to a real Controller in #958
But lets deprecate the routes and remove them in NC12 or so?