fix(API): Remove unused variables and deprecated methods

Signed-off-by: Joas Schilling <coding@schilljs.com>

lib/Controller/SignalingController.php

@@ -53,12 +53,10 @@
 use OCP\DB\Exception;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\Http\Client\IClientService;
-use OCP\IConfig;
 use OCP\IDBConnection;
 use OCP\IRequest;
 use OCP\IUser;
 use OCP\IUserManager;
-use OCP\Security\Bruteforce\IThrottler;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -72,7 +70,6 @@ class SignalingController extends OCSController {
 	public function __construct(
 		string $appName,
 		IRequest $request,
-		IConfig $serverConfig,
 		private Config $talkConfig,
 		private \OCA\Talk\Signaling\Manager $signalingManager,
 		private TalkSession $session,
@@ -86,7 +83,6 @@ public function __construct(
 		private IEventDispatcher $dispatcher,
 		private ITimeFactory $timeFactory,
 		private IClientService $clientService,
-		IThrottler $throttler,
 		private LoggerInterface $logger,
 		private ?string $userId,
 	) {

lib/Middleware/InjectionMiddleware.php

@@ -57,6 +57,7 @@
 use OCP\Federation\ICloudIdManager;
 use OCP\IRequest;
 use OCP\Security\Bruteforce\IThrottler;
+use OCP\Security\Bruteforce\MaxDelayReached;
 
 class InjectionMiddleware extends Middleware {
 	protected bool $isTalkFederation = false;
@@ -316,7 +317,11 @@ public function afterException($controller, $methodName, \Exception $exception):
 						$action = $protection->getAction();
 
 						if ('talkRoomToken' === $action) {
-							$this->throttler->sleepDelay($this->request->getRemoteAddress(), $action);
+							try {
+								$this->throttler->sleepDelayOrThrowOnMax($this->request->getRemoteAddress(), $action);
+							} catch (MaxDelayReached $e) {
+								throw new OCSException($e->getMessage(), Http::STATUS_TOO_MANY_REQUESTS);
+							}
 							$this->throttler->registerAttempt($action, $this->request->getRemoteAddress(), [
 								'token' => $this->request->getParam('token') ?? '',
 							]);