Reaction in video call shows "Guest" to actor, and is not visible to other person

[ChristophWurst]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. Start a call in a 1:1 convo
2. Wait for the other person to join
3. Send a reaction

Expected behaviour

I see the reaction (with my name). The other person sees the reaction with my name.

Actual behaviour

I see the reaction with "Guest". The other person doesn't see it at all.

Talk app

Talk app version: (see apps admin page: /index.php/settings/apps)

Custom Signaling server configured: yes/no and version (see additional admin settings: /index.php/index.php/settings/admin/talk#signaling_server)

Custom TURN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#turn_server)

Custom STUN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#stun_server)

Browser

Microphone available: yes/no

Camera available: yes/no

Operating system: Windows/Ubuntu/...

Browser name: Firefox/Chrome/...

Browser version: 85/96/...

Browser log

``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```

Server configuration

Operating system: Ubuntu/RedHat/...

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 8.0/8.1/8.2

Nextcloud Version: (see admin page)

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your server installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

Server log (data/nextcloud.log)

Insert your server log here

[max-nextcloud]

In a group call earlier today on the same instance people were able to see my reaction fine with my name. I was the only person seeing 'Guest' for my own reactions. For others it was the same - sender sees Guest, everyone else sees their name.

[ChristophWurst]

I have the new typing indicator turned off if that makes any difference

[Antreesy]

Shouldn't be connected to typing indicator.

We handle reactions for yourself with different model. localCallParticipantModel doesn't contain name or display name:
https://github.com/nextcloud/spreed/blob/master/src/utils/webrtc/models/LocalCallParticipantModel.js#L33

So, that could be the reason for seeing "Guest":
Sender:
https://github.com/nextcloud/spreed/blob/master/src/components/TopBar/ReactionMenu.vue#L125

Receiver:
https://github.com/nextcloud/spreed/blob/master/src/components/CallView/shared/ReactionToaster.vue#L140

[nickvergessen]

Only happens with the HPB. Internal signaling works just fine.