Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactions): Fix own call reactions when the HPB is used #9583

Merged
merged 1 commit into from
May 23, 2023
Merged

fix(reactions): Fix own call reactions when the HPB is used #9583

merged 1 commit into from
May 23, 2023

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Guest User display name
grafik Bildschirmfoto vom 2023-05-23 11-14-27

🏁 Checklist

@nickvergessen nickvergessen added this to the 💜 Next Major (28) milestone May 23, 2023
@nickvergessen nickvergessen self-assigned this May 23, 2023
@nickvergessen
Copy link
Member Author

/backport to stable27

Antreesy
Antreesy reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments
Apart from that, should work fine, but I'm unable to test it

src/components/CallView/shared/ReactionToaster.vue Outdated Show resolved Hide resolved
src/components/CallView/shared/ReactionToaster.vue Outdated Show resolved Hide resolved
@nickvergessen
fix(reactions): Fix own call reactions when the HPB is used
0a6fc0a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/9579/self-reactions-with-hpb branch from 6620dfa to 0a6fc0a Compare May 23, 2023 10:26
Antreesy
Antreesy approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@nickvergessen nickvergessen merged commit db8e26b into master May 23, 2023
@nickvergessen nickvergessen deleted the bugfix/9579/self-reactions-with-hpb branch May 23, 2023 11:32
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: reactions 👍
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Reaction in video call shows "Guest" to actor, and is not visible to other person
3 participants
@nickvergessen @marcoambrosini @Antreesy