Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): 🔔 API for "Remind me later" #10079

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 28, 2023

☑️ Resolves

🚧 Tasks

  • Endpoint for clients to trigger a reminder
  • Background job to create the actual notification
  • Test notification is rendered positively

🏁 Checklist

@nickvergessen nickvergessen added 2. developing feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Jul 28, 2023
@nickvergessen nickvergessen added this to the 💜 Next Major (28) milestone Jul 28, 2023
@nickvergessen nickvergessen self-assigned this Jul 28, 2023
@nickvergessen nickvergessen marked this pull request as draft July 28, 2023 17:29
@nickvergessen nickvergessen force-pushed the feat/10077/remind-me-later-api branch 2 times, most recently from 9478f68 to a8fa9d8 Compare August 1, 2023 20:09
@nickvergessen nickvergessen marked this pull request as ready for review August 1, 2023 20:11
@nickvergessen nickvergessen changed the title feat(notification): API for "Remind me later" feat(notification): 🔔 API for "Remind me later" Aug 1, 2023
@nickvergessen nickvergessen force-pushed the feat/10077/remind-me-later-api branch 2 times, most recently from ad2c1b9 to 86d7538 Compare August 2, 2023 07:14
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nextcloud/talk-ios#1320 and worked good!

@nickvergessen
Copy link
Member Author

Ignoring broken oracle CI

@nickvergessen nickvergessen merged commit 40dbcbb into master Aug 3, 2023
26 of 28 checks passed
@nickvergessen nickvergessen deleted the feat/10077/remind-me-later-api branch August 3, 2023 11:09
@nickvergessen
Copy link
Member Author

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Notify me later about this message - API
2 participants