Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CallTime)- add one hour hint during the call #10086

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Aug 1, 2023

☑️ Resolves

Description

The Hint text
[ design]

Note the call is running since 1 hour already.

  • The Hint gets shown at 1:00:00, and the popover stays open for 10s if the user didn't trigger outside focus.

  • After that, The Hint remains in the popover and it is accessed by clicking on the call time.

  • If the User is a moderator, the hint is added to the recording buttons popover.

🖼️ Screenshots

This is a recording for a hint faked at 2:20 :

1hourHint2023-08-01.140550.mp4

The moderator's popover ( e.g in case the recording is starting)

image

🚧 Tasks

  • To test :
    If you don't want to wait for one hour, change this line and you can only wait for 20 sec and it can be repeated with 1 min interval.
      this.untilOneHourHint = (1000 * 20) - this.timer + 1
  • code review
  • Visual review

🏁 Checklist

@DorraJaouad DorraJaouad self-assigned this Aug 1, 2023
@DorraJaouad DorraJaouad added this to the 💜 Next Major (28) milestone Aug 1, 2023
@DorraJaouad
Copy link
Contributor Author

@jancborchardt , how about

The call has been running for one hour.

@DorraJaouad DorraJaouad marked this pull request as ready for review August 1, 2023 13:28
@jancborchardt
Copy link
Member

@DorraJaouad your text auggestion sounds better indeed!

And it looks good, except it could use some more padding to the top and sides so it's consistent on all sides.

src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See code comments

src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/9947/show-hint-in-call-after-one-hour branch 2 times, most recently from b568de1 to a97ed06 Compare August 1, 2023 15:04
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/components/TopBar/CallTime.vue Outdated Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/9947/show-hint-in-call-after-one-hour branch from 4150484 to 833af71 Compare August 2, 2023 13:59
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on web client, works good!

Also call timer is much more responsive now

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/9947/show-hint-in-call-after-one-hour branch from 34671d6 to f52277e Compare August 2, 2023 21:06
@Antreesy Antreesy dismissed jancborchardt’s stale review August 3, 2023 11:17

Code style and CSS styles have been aligned since last review

@DorraJaouad DorraJaouad merged commit c16f4a4 into master Aug 3, 2023
18 checks passed
@DorraJaouad DorraJaouad deleted the feat/9947/show-hint-in-call-after-one-hour branch August 3, 2023 12:07
@DorraJaouad
Copy link
Contributor Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show hint when call is running since 1 hour
3 participants