-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CallTime)- add one hour hint during the call #10086
Conversation
@jancborchardt , how about
|
@DorraJaouad your text auggestion sounds better indeed! And it looks good, except it could use some more padding to the top and sides so it's consistent on all sides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See code comments
b568de1
to
a97ed06
Compare
4150484
to
833af71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on web client, works good!
Also call timer is much more responsive now
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
34671d6
to
f52277e
Compare
Code style and CSS styles have been aligned since last review
/backport to stable27 |
☑️ Resolves
Description
The Hint text
[ design]
The Hint gets shown at 1:00:00, and the popover stays open for 10s if the user didn't trigger outside focus.
After that, The Hint remains in the popover and it is accessed by clicking on the call time.
If the User is a moderator, the hint is added to the recording buttons popover.
🖼️ Screenshots
This is a recording for a hint faked at 2:20 :
1hourHint2023-08-01.140550.mp4
The moderator's popover ( e.g in case the recording is starting)
🚧 Tasks
If you don't want to wait for one hour, change this line and you can only wait for 20 sec and it can be repeated with 1 min interval.
🏁 Checklist
docs/
has been updated or is not required