Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Message) - 🔔 add frontend support for message reminders #10105

Merged
merged 6 commits into from
Aug 9, 2023
+380 −77
Merged

feat(Message) - 🔔 add frontend support for message reminders #10105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5ae729
provide container and boundaries for Popover via computed properties
Antreesy Aug 8, 2023
08bee7a
add a reminders service
Antreesy Aug 8, 2023
6c626f6
add submenu in MessageButtonsBar.vue for reminder actions
Antreesy Aug 8, 2023
3bc580b
add capabilities check
Antreesy Aug 8, 2023
7fdfeb9
shorten boolean props
Antreesy Aug 9, 2023
01648ba
show currently set reminder, add ability to remove it
Antreesy Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/MessagesList/MessagesGroup/Message/Message.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ describe('Message.vue', () => {
bottom: 0,
left: 0,
},
getMessagesListScroller: jest.fn(),
}

testStoreConfig = cloneDeep(storeConfig)
Expand Down
24 changes: 24 additions & 0 deletions ...components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ describe('MessageButtonsBar.vue', () => {
let testStoreConfig
let store
let messageProps
let injected
let conversationProps
let getActorTypeMock

Expand Down Expand Up @@ -87,6 +88,20 @@ describe('MessageButtonsBar.vue', () => {

beforeEach(() => {
store = new Store(testStoreConfig)

injected = {
scrollerBoundingClientRect: {
x: 0,
y: 0,
width: 0,
height: 0,
top: 0,
right: 0,
bottom: 0,
left: 0,
},
getMessagesListScroller: jest.fn(),
}
})

describe('reply action', () => {
Expand All @@ -103,6 +118,7 @@ describe('MessageButtonsBar.vue', () => {
NcButton,
},
propsData: messageProps,
provide: injected,
})

const replyButton = findNcButton(wrapper, 'Reply')
Expand Down Expand Up @@ -137,6 +153,7 @@ describe('MessageButtonsBar.vue', () => {
NcButton,
},
propsData: messageProps,
provide: injected,
})

const replyButton = findNcButton(wrapper, 'Reply')
Expand Down Expand Up @@ -165,6 +182,7 @@ describe('MessageButtonsBar.vue', () => {
NcActionButton,
},
propsData: messageProps,
provide: injected,
})

const actionButton = findNcActionButton(wrapper, 'Reply privately')
Expand Down Expand Up @@ -199,6 +217,7 @@ describe('MessageButtonsBar.vue', () => {
NcActionButton,
},
propsData: messageProps,
provide: injected,
})

const actionButton = findNcActionButton(wrapper, 'Reply privately')
Expand Down Expand Up @@ -243,6 +262,7 @@ describe('MessageButtonsBar.vue', () => {
NcActionButton,
},
propsData: messageProps,
provide: injected,
})

const actionButton = findNcActionButton(wrapper, 'Delete')
Expand Down Expand Up @@ -278,6 +298,7 @@ describe('MessageButtonsBar.vue', () => {
NcActionButton,
},
propsData: messageProps,
provide: injected,
})

const actionButton = findNcActionButton(wrapper, 'Delete')
Expand Down Expand Up @@ -356,6 +377,7 @@ describe('MessageButtonsBar.vue', () => {
},

propsData: messageProps,
provide: injected,
})

const actionButton = findNcActionButton(wrapper, 'Mark as unread')
Expand Down Expand Up @@ -397,6 +419,7 @@ describe('MessageButtonsBar.vue', () => {
},

propsData: messageProps,
provide: injected,
})

Object.assign(navigator, {
Expand Down Expand Up @@ -435,6 +458,7 @@ describe('MessageButtonsBar.vue', () => {
NcActionButton,
},
propsData: messageProps,
provide: injected,
})

const actionButton = findNcActionButton(wrapper, 'first action')
Expand Down
Loading
Loading