Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SearchBox) - unify component handling #10325

Merged
merged 3 commits into from
Aug 24, 2023
Merged

fix(SearchBox) - unify component handling #10325

merged 3 commits into from
Aug 24, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Manual testing
  • Code review

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Aug 23, 2023
@Antreesy Antreesy self-assigned this Aug 23, 2023
@Antreesy
handle isFocused state internally
3c80d63 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
handle trailing button Enter keydown event
585eb15 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
move common styles from parent components
c5c28c0 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

/backport to stable27

nickvergessen
nickvergessen approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine :)

@Antreesy Antreesy merged commit 33729cc into master Aug 24, 2023
18 checks passed
@Antreesy Antreesy deleted the fix/noid/unify-search-box branch August 24, 2023 07:26
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: search 🔎
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

No ❌ available on participant list filter to clear search term
2 participants
@Antreesy @nickvergessen