Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Fix responding with "X-Chat-Last-Common-Read" when request… #10332

Merged

Conversation

nickvergessen
Copy link
Member

…ed by the client

☑️ Resolves

Before

    Then last response has last common read message header set to "Message 3"               # FeatureContext::hasChatLastCommonReadHeader()
    When next message request has the following parameters set                              # FeatureContext::setChatParametersForNextRequest()
      | lastCommonReadId   | Message 1 |
      | lastKnownMessageId | Message 3 |
      | timeout            | 0         |
      | lookIntoFuture     | 1         |
    Then user "participant1" sees the following messages in room "chatting" with 200        # FeatureContext::userSeesTheFollowingMessagesInRoom()
      ❌ Failed asserting that 304 matches expected 200.

🏁 Checklist

…ed by the client

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Aug 24, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Aug 24, 2023
@nickvergessen nickvergessen self-assigned this Aug 24, 2023
@nickvergessen
Copy link
Member Author

/backport to stable27

@nickvergessen
Copy link
Member Author

/backport to stable26

…ameters must not be accessed before initialization

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 1bb0ef4 into master Aug 24, 2023
24 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-responding-with-last-common-read-header branch August 24, 2023 08:46
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants