Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NewMessage, EditabeTextField) - don't parse NcRichContenteditable output before sending #10422

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix(NewMessage, EditabeTextField) - don't parse NcRichContenteditable output before sending #10422

merged 2 commits into from
Aug 31, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 30, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

Input:

&amp &lt &gt &sect
& < > §
https://instance.com/?editor=globaladmin&section=Invitation

Output:

🏚️ Before 🏡 After
image image
image image
& < > § & < > § https://instancae.com/?editor=globaladmin§ion=Invitation &amp &lt &gt &sect & < > § https://instancae.com/?editor=globaladmin&section=Invitation

🚧 Tasks

  • Code review
  • Visual check

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Aug 30, 2023
@Antreesy Antreesy self-assigned this Aug 30, 2023
DorraJaouad
DorraJaouad requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like an issue with text storing in NcRichContenteditable ?

Recording.2023-08-31.140506.mp4

@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 31, 2023 •
edited
Loading

It seems like an issue with text storing in NcRichContenteditable ?

Yes, that's how the component gives away the output, it escapes all special symbols for security reasons

@Antreesy Antreesy force-pushed the fix/10227/ncrichcontent-parsing branch from 0d9d202 to 51c84ac Compare August 31, 2023 14:10
@Antreesy
Copy link
Contributor Author

P.S. updated PR, raised and referenced an upstream issue

@Antreesy
escape special symbols when parsing NcRichContenteditable output
dcaa0c0 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
render conversation name and description in settings with NcRichText
ebc0ea3 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/10227/ncrichcontent-parsing branch 2 times, most recently from cbb5c73 to ebc0ea3 Compare August 31, 2023 16:30
nickvergessen
nickvergessen approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

@nickvergessen nickvergessen merged commit 04ce9e5 into master Aug 31, 2023
23 checks passed
@nickvergessen nickvergessen deleted the fix/10227/ncrichcontent-parsing branch August 31, 2023 17:10
@Antreesy
Copy link
Contributor Author

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 31, 2023
Merged
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Sep 6, 2023
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: chat 💬 Chat and system messages feature: conversations 👥 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Pasted URL in Talk gets changed once posted
3 participants
@Antreesy @nickvergessen @DorraJaouad