Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneccessary output from php process #10444

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

SystemKeeper
Copy link
Contributor

@SystemKeeper SystemKeeper commented Aug 31, 2023

☑️ Resolves

  • Removes unneccessary output of "Accepted" and "Closed" messages from the PHP dev server.
  • Fixes the trap. Since we can have only one trap per signal, this is now combined.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

@SystemKeeper SystemKeeper marked this pull request as draft August 31, 2023 18:54
tests/integration/run.sh Outdated Show resolved Hide resolved
tests/integration/run.sh Outdated Show resolved Hide resolved
@SystemKeeper SystemKeeper force-pushed the clean-integration-log-output branch 2 times, most recently from 1cb11f8 to 224d240 Compare September 6, 2023 17:28
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper marked this pull request as ready for review September 6, 2023 18:44
@SystemKeeper
Copy link
Contributor Author

Done as discussed. In the conversation test we are now down from approx. 18000 to 8000 lines.

@nickvergessen nickvergessen merged commit 57fb33b into master Sep 18, 2023
45 checks passed
@nickvergessen nickvergessen deleted the clean-integration-log-output branch September 18, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants