Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

techdebt(LoadingPlaceholder) - rewrite skeleton component #10489

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 11, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before

Participants had different component as placeholder:

skeleton-pulse.webm

🏡 After

Animation flow:

skeleton-wave.webm

In normal colors:

skeleton-light-theme.webm
skeleton-dark-theme.webm

🚧 Tasks

  • Manual testing
  • Code review
  • Design review

🏁 Checklist

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice from design perspective! 🚀

Does it also look good in dark mode? (was a problem until recently IIRC)...

@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 13, 2023

Does it also look good in dark mode? (was a problem until recently IIRC)...

Have updated screencasts for both dark and light themes, please see in the root description

UPD: rebased onto master, increased wave width and speed a bit

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's better than before 🦅. The animation looks fine and code-wise, it is more dynamic and concise. Just a tweak suggestion.

src/components/LoadingPlaceholder.vue Show resolved Hide resolved
src/components/LoadingPlaceholder.vue Outdated Show resolved Hide resolved
src/components/LoadingPlaceholder.vue Outdated Show resolved Hide resolved
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

Rebased onto master with post-review fix, no other changes

@Antreesy Antreesy merged commit 0724e0c into master Sep 14, 2023
23 checks passed
@Antreesy Antreesy deleted the feat/noid/redo-placeholder branch September 14, 2023 11:47
@Antreesy
Copy link
Contributor Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants