Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(participantsStore) - handle participants fetch through the store #10523

Merged
merged 5 commits into from
Sep 19, 2023
Merged

fix(participantsStore) - handle participants fetch through the store #10523

merged 5 commits into from
Sep 19, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix [Bug] Participants list is fetched twice from server #10497
    • Previously for users and guest moderators participants were fetched twice, from RightSidebar and TopBar
    • CancelledRequest logic was there, but because it was in mixin, it doesn't work for different components as expected
    • TopBar duplicates request for participants counter in call only - it's not needed for registered users at all
    • TopBar watches if guest was promoted to guest-moderator to fetch participants

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • create fetchParticipants action from the current code and move to participantsStore
  • cover an action with tests
  • move logic for guests from TopBar to RightSidebar
  • handle case when guest moderator was demoted

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Sep 17, 2023
@Antreesy Antreesy self-assigned this Sep 17, 2023
@Antreesy
Revert "move guestNameStore initialisation from mixin to components"
a0f8a99 
This reverts commit 7a2e614.

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
move 'fetchParticipants' as action to participantsStore
9bab004 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
rearrange tests in participantsStore.spec.js
c5a28de 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
add test coverage for fetchParticipants action
00cbbdd 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
remove getParticipants mixin from TopBar, redo logic for guest modera…
d17d9df 
…tors

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/10497/cancel-second-request branch from 167b3f2 to d17d9df Compare September 17, 2023 13:22
DorraJaouad
DorraJaouad approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy merged commit deb906b into master Sep 19, 2023
23 checks passed
@Antreesy Antreesy deleted the fix/10497/cancel-second-request branch September 19, 2023 14:21
@Antreesy
Copy link
Contributor Author

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: conversations 👥 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

[Bug] Participants list is fetched twice from server
2 participants
@Antreesy @DorraJaouad