Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event): Strict type the event after clarification with event cons… #10756

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

nickvergessen
Copy link
Member

…umers

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt labels Oct 23, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Oct 23, 2023
@nickvergessen nickvergessen self-assigned this Oct 23, 2023
…umers

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/fix-type-after-clarification branch from b51445f to b651008 Compare October 23, 2023 07:16
Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nickvergessen nickvergessen merged commit 5ac7406 into master Oct 24, 2023
47 checks passed
@nickvergessen nickvergessen deleted the techdebt/noid/fix-type-after-clarification branch October 24, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants