Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uploads): allow to send empty uploads as normal messages #10986

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix(uploads): allow to send empty uploads as normal messages #10986

merged 1 commit into from
Nov 27, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 23, 2023 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏡 After

empty.upload.mp4

🚧 Tasks

  • Upstream: NcRichContenEditable should place caret in the end, when focused

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Nov 23, 2023
@Antreesy Antreesy self-assigned this Nov 23, 2023
@Antreesy
allow to send normal message if no uploads attached
74a827d 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy marked this pull request as ready for review November 24, 2023 11:48
SystemKeeper
SystemKeeper approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised ;)
Nice 👍

@Antreesy Antreesy merged commit ee8e2dd into main Nov 27, 2023
37 checks passed
@Antreesy Antreesy deleted the fix/10872/fix-empty-uploads branch November 27, 2023 08:58
@Antreesy
Copy link
Contributor Author

/backport to stable28

@Antreesy Antreesy mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@ShGKme ShGKme ShGKme approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

File caption is lost if files are removed
5 participants
@Antreesy @SystemKeeper @ShGKme @marcoambrosini @nickvergessen