-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shares): allow to retry failed uploads #11107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
2. developing
bug
feature: frontend 🖌️
"Web UI" client
feature: upload & shares & voice 📤🎙️
Sharing files into a chat and audio recordings
labels
Dec 4, 2023
Antreesy
force-pushed
the
fix/10768/retry-failed-uploads
branch
from
December 15, 2023 11:50
d51cf38
to
5584fcc
Compare
/backport to stable28 |
DorraJaouad
reviewed
Dec 15, 2023
DorraJaouad
reviewed
Dec 16, 2023
DorraJaouad
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 🦅
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
DorraJaouad
force-pushed
the
fix/10768/retry-failed-uploads
branch
from
December 18, 2023 10:36
5c3c31c
to
63ad366
Compare
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
bug
feature: frontend 🖌️
"Web UI" client
feature: upload & shares & voice 📤🎙️
Sharing files into a chat and audio recordings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
retry-upload.webm
Tip
Add
if (Math.random() < 0.5) throw new Error()
toperformUpload
function to fail some uploads🏁 Checklist