Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(federations): provide admin setting to enable Federation in Talk #11294

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 26, 2023

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image

🚧 Tasks

  • Check wording

🏁 Checklist


🛠️ API Checklist

🚧 Tasks

  • Check code changes

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Antreesy Antreesy added 2. developing feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: federation 🌐 labels Dec 26, 2023
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Dec 26, 2023
@Antreesy Antreesy self-assigned this Dec 26, 2023
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should at least hide it when not on debug mode, so we don't forget about it.

Or we default federation to enabled when debug is on, then you also don't need the setting for now, right?

src/components/AdminSettings/Federations.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/11279/handle-federations-invite branch 2 times, most recently from 686cc59 to 0400685 Compare January 10, 2024 13:54
@Antreesy
Copy link
Contributor Author

Or we default federation to enabled when debug is on, then you also don't need the setting for now, right?

Made changes, now it's visible in debug mode only
I'd keep in configurable anyway. For now it's a good base for putting here new settings, if they'll arise one day.

@Antreesy Antreesy changed the title feat(federations): provide admin setting to enable federations in Talk on instance feat(federations): provide admin setting to enable Federation in Talk Jan 18, 2024
@Antreesy Antreesy marked this pull request as ready for review January 18, 2024 14:32
src/App.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/11279/handle-federations-invite branch from 0400685 to 510898a Compare January 19, 2024 10:30
…k on instance

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/11279/handle-federations-invite branch from 510898a to 56a0918 Compare January 19, 2024 11:03
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and wording is fine.

@Antreesy Antreesy merged commit ea74545 into main Jan 19, 2024
54 checks passed
@Antreesy Antreesy deleted the feat/11279/handle-federations-invite branch January 19, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants