Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shares): pass the correct payload to the upload method #11330

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 2, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🚧 Tasks

  • Test file upload against server stable27
    • Curent step is fixed for me, but local setup doesn't upload files because of CORS probably

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Jan 2, 2024
@Antreesy Antreesy requested a review from ShGKme January 2, 2024 12:37
@Antreesy Antreesy self-assigned this Jan 2, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 2, 2024

/backport to stable28

@Antreesy Antreesy merged commit c61fd9c into main Jan 2, 2024
36 checks passed
@Antreesy Antreesy deleted the fix/473/fix-desktop-upload branch January 2, 2024 13:00
@ShGKme

This comment was marked as resolved.

@Antreesy

This comment was marked as resolved.

@ShGKme
Copy link
Contributor

ShGKme commented Jan 10, 2024

Oh, right. No need to change anything on the server for Talk Desktop. Sorry, tied, The backport just wasn't released yet 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File sending not working
2 participants