Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mixins): migrate device mixin to composable #11333

Merged
merged 2 commits into from
Jan 7, 2024
Merged

chore(mixins): migrate device mixin to composable #11333

merged 2 commits into from
Jan 7, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 3, 2024

☑️ Resolves

  • Migrate mixin for MediaDevicesPreview and MediaSettings to composable
  • Move some code to the component, clean props

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visua changes

🚧 Tasks

  • Code review
  • Manual testing

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added 3. to review feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients technical debt feature: frontend 🖌️ "Web UI" client labels Jan 3, 2024
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Jan 3, 2024
@Antreesy Antreesy self-assigned this Jan 3, 2024
@Antreesy Antreesy force-pushed the fix/noid/migrate-device-mixin branch from bbe8f3d to 4b2a2d1 Compare January 4, 2024 15:10
ShGKme
ShGKme approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good according to the code, but haven't tested...

DorraJaouad
DorraJaouad approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, code-wise also good.

@Antreesy
fix(mixins): attach prop and computed labels to corresponding component
0ab5f04 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(mixins): migrate devices mixin
56a7a22 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/migrate-device-mixin branch from 30095be to 56a7a22 Compare January 7, 2024 19:34
@Antreesy Antreesy merged commit 38d19fe into main Jan 7, 2024
36 checks passed
@Antreesy Antreesy deleted the fix/noid/migrate-device-mixin branch January 7, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad