Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactions): add guardian before resetting reactions #11343

Merged
merged 1 commit into from
Jan 6, 2024
Merged

fix(reactions): add guardian before resetting reactions #11343

merged 1 commit into from
Jan 6, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 6, 2024

☑️ Resolves

  • Fix resetReactions action, which prevents rendering of following messages
  • Add test for purgeReactionsStore

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Jan 6, 2024
@Antreesy Antreesy self-assigned this Jan 6, 2024
@Antreesy
fix(reactions): add guardian before reset reactions, increase test co…
ee44f01 
…verage

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/add-check-existence branch from 12abf77 to ee44f01 Compare January 6, 2024 13:20
DorraJaouad
DorraJaouad approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Antreesy Antreesy merged commit 9b7a2c4 into main Jan 6, 2024
36 checks passed
@Antreesy Antreesy deleted the fix/noid/add-check-existence branch January 6, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: reactions 👍
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad