Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): Store and expose whether a message or call was silent #11449

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat(chat): Store and expose whether a message or call was silent #11449

merged 1 commit into from
Jan 31, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 25, 2024 •
edited
Loading

☑️ Resolves

🛠️ API Checklist

grafik

🚧 Tasks

  • Store flag
  • Expose as message property
  • Resolve FIXMEs in editMessage code

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 2. developing enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls labels Jan 25, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Jan 25, 2024
@nickvergessen nickvergessen self-assigned this Jan 25, 2024
@nickvergessen nickvergessen marked this pull request as draft January 25, 2024 14:41
@nickvergessen
Copy link
Member Author

Chat manager is best reviewed with ?w=1 https://github.com/nextcloud/spreed/pull/11449/files?w=1

@nickvergessen
feat(chat): Store and expose whether a message or call was silent
0d1fc13 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/8234/store-and-expose-silent-send branch from db2829a to 0d1fc13 Compare January 30, 2024 11:38
@nickvergessen nickvergessen marked this pull request as ready for review January 30, 2024 11:39
SystemKeeper
SystemKeeper approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen nickvergessen merged commit e63edd4 into main Jan 31, 2024
54 checks passed
@nickvergessen nickvergessen deleted the feat/8234/store-and-expose-silent-send branch January 31, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@mahibi mahibi Awaiting requested review from mahibi

@Ivansss Ivansss Awaiting requested review from Ivansss

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Visual indication for silently sent messages
2 participants
@nickvergessen @SystemKeeper