Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pinia): migrate breakoutRoomsStore to Pinia 🍍 #11649

Merged
merged 2 commits into from
Mar 25, 2024
Merged

refactor(pinia): migrate breakoutRoomsStore to Pinia 🍍 #11649

merged 2 commits into from
Mar 25, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 25, 2024 •
edited
Loading

  • Migrate breakoutRoomsStore to Pinia 🍍
    • optimize some methods
    • rename **Action to normal ones

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🚧 Tasks

  • Pinia migration
  • Typescript migration - in follow-up
  • Test coverage - in follow-up

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Feb 25, 2024
@Antreesy Antreesy self-assigned this Feb 25, 2024
@Antreesy Antreesy force-pushed the refactor/noid/migrate-breakout-store branch from 17d9d25 to 9cf9e1e Compare March 5, 2024 12:48
@Antreesy
refactor(pinia): migrate breakoutRoomsStore to Pinia
786e04e 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the refactor/noid/migrate-breakout-store branch from 9cf9e1e to 358a262 Compare March 22, 2024 09:53
@Antreesy Antreesy marked this pull request as ready for review March 22, 2024 09:57
@Antreesy Antreesy mentioned this pull request Mar 22, 2024
Merged
3 tasks
DorraJaouad
DorraJaouad reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing :
image
Participants are not in their right room.

Also, is it expected to return room-not-found when reassigning a participant to the room where you are currently joining the call?

src/stores/breakoutRooms.js Outdated Show resolved Hide resolved
src/stores/breakoutRooms.js Outdated Show resolved Hide resolved
src/stores/breakoutRooms.js Outdated Show resolved Hide resolved
src/stores/breakoutRooms.js Outdated Show resolved Hide resolved
@Antreesy

This comment was marked as off-topic.

Sign in to view
@DorraJaouad

This comment was marked as off-topic.

Sign in to view
@Antreesy

This comment was marked as off-topic.

Sign in to view
This was referenced Mar 25, 2024
Open
Closed
@Antreesy Antreesy force-pushed the refactor/noid/migrate-breakout-store branch from 358a262 to fabb220 Compare March 25, 2024 11:13
@Antreesy
refactor(pinia): refactor and rename store methods
0b7330a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the refactor/noid/migrate-breakout-store branch from fabb220 to 0b7330a Compare March 25, 2024 11:24
DorraJaouad
DorraJaouad approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As follow-ups are there, this is ready

@Antreesy Antreesy merged commit 38a03ec into main Mar 25, 2024
46 checks passed
@Antreesy Antreesy deleted the refactor/noid/migrate-breakout-store branch March 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: breakout rooms 🖖 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @DorraJaouad @nickvergessen