Tighten MessageType and ActorType usage #11696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
refactor/tighten-messagetype-actortype-method-types
branch
from
6bfd66a
to
616b3a1
Compare
|
Looks like the default values need to be kept, but that violates the enums and we know that the values will always be set. |
Only later on. when you do |
3 tasks
|
This can sadly not be fixed in a proper way because of the empty string as a default value. If it was null then it wouldn't be a problem, but string enums with an empty string as default are bad. |
provokateurin
deleted the
refactor/tighten-messagetype-actortype-method-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
I added the missing message types and tightened the types of the message type and actor type methods to ensure only valid values will be passed. It's not possible to do this with virtual methods (
@psalm-methodexists but doesn't seem to work).🏁 Checklist
docs/has been updated or is not required