fix(messages): minor render enhancements #11727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nickvergessen |
This was required for some things when switching from chat UI to call UI. Can not remember the details though |
Was introduced here: 7503ecf |
- assign `viewId` on Options API initialising: chatIdentifier is no longer updated at `mounted()` - no cancelled requests - add a safe check for system messages without parents - doesn't happen usually, but for federated conversations system conversations `getContext` response is processed as if there are no message parents - system message is rendered in the list Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/message-list-render
branch
from
4fe60fe
to
cbc649d
Compare
nickvergessen
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
viewIdon Options API initialising: chatIdentifier is no longer updated atmounted()- no cancelled requestsgetContextat the moment response is processed, doesn't contain message parent - false check - system message is rendered as-is🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist