Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(participants): move interval update of talking time counter to the store #11782

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix(participants): move interval update of talking time counter to the store #11782

merged 2 commits into from
Mar 14, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 12, 2024 •
edited
Loading

☑️ Resolves

  • Fix Talking time is transferred to other participants #11501
    • Data in the store are correct and accessible by token + attendeeId
    • Because of virtual scroller in the participant list, interval update in the component can't be used, as it attached to the Vue component object, not the participant data
    • Moved interval update to the store, so each second we update a value there
    • Component rely only on store update and re-rendered once per second (as before), but with correct value

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Reproducible Non-reproducible

🚧 Tasks

  • speaking don't rely on participantStore, so may be moved to callExtras store 🍍
    • Check if SpeakingStatusHandler class supports Pinia

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 12, 2024
@Antreesy Antreesy self-assigned this Mar 12, 2024
DorraJaouad
DorraJaouad reviewed Mar 12, 2024
View reviewed changes
src/components/RightSidebar/Participants/Participant.vue Show resolved Hide resolved
src/components/RightSidebar/Participants/Participant.vue Outdated Show resolved Hide resolved
src/store/participantsStore.js Outdated Show resolved Hide resolved
src/store/participantsStore.js Outdated Show resolved Hide resolved
src/store/participantsStore.js Outdated Show resolved Hide resolved
src/store/participantsStore.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad mentioned this pull request Mar 12, 2024
Closed
6 tasks
@Antreesy Antreesy force-pushed the fix/11501/keep-talking-time branch 2 times, most recently from 39868a1 to 31c9833 Compare March 13, 2024 16:07
DorraJaouad
DorraJaouad reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last time 😬

src/store/participantsStore.js Outdated Show resolved Hide resolved
src/store/participantsStore.js Outdated Show resolved Hide resolved
src/store/participantsStore.js Outdated Show resolved Hide resolved
src/store/participantsStore.js Outdated Show resolved Hide resolved
src/store/participantsStore.js Outdated Show resolved Hide resolved
@Antreesy
fix(participants): move interval update of talking time counter to th…
8924fe7 
…e store

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/11501/keep-talking-time branch from 31c9833 to dd9540c Compare March 14, 2024 09:36
@Antreesy
fix(participants): flatten the store data for speaking state
708d4f8 
- we assume there's only one active call at the moment, and purge speaking data when leave call, so it's safe to store them without token

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/11501/keep-talking-time branch from dd9540c to 708d4f8 Compare March 14, 2024 09:53
DorraJaouad
DorraJaouad approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

@Antreesy Antreesy enabled auto-merge March 14, 2024 09:54
@Antreesy
Copy link
Contributor Author

/backport to stable28

@Antreesy Antreesy merged commit 4eb698f into main Mar 14, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/11501/keep-talking-time branch March 14, 2024 10:04
@backportbot backportbot bot mentioned this pull request Mar 14, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

Talking time is transferred to other participants
2 participants
@Antreesy @DorraJaouad