Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Allow negative expiration time in tests #11895

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix(tests): Allow negative expiration time in tests #11895

merged 1 commit into from
Mar 22, 2024

Conversation

nickvergessen
Copy link
Member

Fix #11115

🏚️ Before 🏡 After
Bildschirmfoto vom 2024-03-22 12-22-38 Bildschirmfoto vom 2024-03-22 12-22-25

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(tests): Allow negative expiration time in tests
cebfb4c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Mar 22, 2024
@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 22, 2024
@nickvergessen nickvergessen self-assigned this Mar 22, 2024
SystemKeeper
SystemKeeper approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it would probably be better to have the dash separate, but for a test this is fine.

@nickvergessen nickvergessen merged commit 5b14e12 into main Mar 22, 2024
64 checks passed
@nickvergessen nickvergessen deleted the bugfix/11115/fix-integration-test branch March 22, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v19.0.0-beta.5
Development

Successfully merging this pull request may close these issues.

Integration test features/chat/message-expiration.feature:7 looks skipped on CI, needs investigation
2 participants
@nickvergessen @SystemKeeper