-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(OpenConversationsList): expose description #12243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
reviewed
Apr 29, 2024
src/components/LeftSidebar/ConversationsList/ConversationSearchResult.vue
Outdated
Show resolved
Hide resolved
DorraJaouad
force-pushed
the
feat/12209/show-description
branch
from
April 29, 2024 15:05
90a204e
to
0365544
Compare
Antreesy
reviewed
Apr 30, 2024
Added API test |
DorraJaouad
force-pushed
the
feat/12209/show-description
branch
2 times, most recently
from
April 30, 2024 14:16
776c66a
to
ecf8d36
Compare
Antreesy
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looks better now. Please check comments (for further improvement, maybe?)
src/components/LeftSidebar/ConversationsList/ConversationSearchResult.vue
Outdated
Show resolved
Hide resolved
DorraJaouad
force-pushed
the
feat/12209/show-description
branch
from
May 2, 2024 18:33
ecf8d36
to
f25ae56
Compare
Antreesy
reviewed
May 3, 2024
DorraJaouad
force-pushed
the
feat/12209/show-description
branch
from
May 3, 2024 14:23
46dcbc5
to
d52b580
Compare
Antreesy
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looks good!
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
feat/12209/show-description
branch
from
May 4, 2024 06:44
d52b580
to
3d65a1e
Compare
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…posed for listed rooms Signed-off-by: Joas Schilling <coding@schilljs.com>
DorraJaouad
force-pushed
the
feat/12209/show-description
branch
from
May 4, 2024 07:14
3d65a1e
to
2a20afd
Compare
This was referenced May 6, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
exposeDescription
injection and it has a priority overexposeMessage
-> maybe the opposite is better ?exposeMessage
andexposeDescription
are not needed to be reactive, simplified them to booleans🏁 Checklist
🛠️ API Checklist
🏁 Checklist
docs/
has been updated or is not required