Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: design adjustments for Nc30 #12767

Merged
merged 7 commits into from
Jul 22, 2024
Merged

style: design adjustments for Nc30 #12767

merged 7 commits into from
Jul 22, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 20, 2024

☑️ Resolves

  • Fix some topic from daily design review
  • Tested with nextcloud-vue@main, so need to release for some upstream changes
  • Search box
    • text moves on hover upstream
    • buttons are too far
  • List items in conversation list
    • Spacing on the left too much upstream ?
    • Avatar circle is slightly cut off upstream
    • Avatar circle should have transparant bg + same bg on hover
  • Create new conversation dialog
    • Use JS autosize for description so it auto resizes upstream
    • lock horizontal resizing
  • NewMessage input
    • emoji doesn't have hover feedback
  • MessageButtonsBar
    • lift a bit for sticky position
    • if date and buttons are on the same level, buttons dissapear (hover event at date should be disabled)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
before after

🚧 Tasks

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team

@ShGKme
Copy link
Contributor

ShGKme commented Jul 20, 2024

Making list items huge again seams like design reverting

@Antreesy
Copy link
Contributor Author

Antreesy commented Jul 20, 2024

Making list items huge again seams like design reverting

Do we maybe have overwriting somewhere?

UPD: reduced height a bit, but we still have from upstream
height: 48px (2 lines) + 8*2 px (padding top/bottom) + 4*2px (outline offest compensation)

B A
image image

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…ichContenteditable

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…pointer events for messages date

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

Merging to get for the daily review

@Antreesy Antreesy merged commit 1213e2d into main Jul 22, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/design-adjust-v2 branch July 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants