Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(avatar): decrease avatar size from 44px to 36px #12956

Merged
merged 3 commits into from
Aug 15, 2024
Merged

fix(avatar): decrease avatar size from 44px to 36px #12956

merged 3 commits into from
Aug 15, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 13, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Aug 13, 2024
@Antreesy Antreesy self-assigned this Aug 13, 2024
@Antreesy Antreesy changed the title fix(avatar): decrease avatar size from 44px to 38px fix(avatar): decrease avatar size from 44px to 36px Aug 14, 2024
@Antreesy Antreesy requested a review from ShGKme August 14, 2024 14:21
marcoambrosini
marcoambrosini reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The position of the status icon also needs to change, likely 2px up and 2px left

@nickvergessen
Copy link
Member

/backport to stable30

@Antreesy
fix(avatar): decrease avatar size from 44px to 36px
7043739 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(NcListItem): decrease line height from 1.5 to 1.2
8ce30cc 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: adjust user status / conversation type size and position
2bae552 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit 4bda31d into main Aug 15, 2024
47 checks passed
@Antreesy Antreesy deleted the feat/noid/shrink-avatars branch August 15, 2024 12:54
@backportbot backportbot bot mentioned this pull request Aug 15, 2024
Merged
@ShGKme ShGKme mentioned this pull request Aug 22, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@ShGKme ShGKme Awaiting requested review from ShGKme

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Antreesy Antreesy

Labels
3. to review design feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @nickvergessen @ShGKme @marcoambrosini