Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate pollService to TS #13465

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix: migrate pollService to TS #13465

merged 2 commits into from
Oct 7, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 4, 2024

☑️ Resolves

  • Prerequisite to further polls PRs

🖌️ UI Checklist

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possibleSigned-off-by: Maksim Sukharev antreesy.web@gmail.com

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 4, 2024
@Antreesy Antreesy self-assigned this Oct 4, 2024
DorraJaouad
DorraJaouad approved these changes Oct 7, 2024
View reviewed changes
src/stores/polls.ts Outdated Show resolved Hide resolved
@Antreesy
fix: migrate pollService to TS
05ed216 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: migrate polls store to TS
bfdd93b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit b2d25cd into main Oct 7, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/polls-ts branch October 7, 2024 15:22
@Antreesy
Copy link
Contributor Author

Antreesy commented Oct 7, 2024

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client feature: polls 📊 technical debt
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad