Fix memory leak in message list #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be needed to unsubscribe the handlers, as it was not possible to refer to the arrow functions from other parts of the code. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This fixes a memory leak of the message list as well as any other component that the message list is part of (like the chat view due to the parent component reference of Vue). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: chat 💬
|
/backport to stable19 |
|
/backport to stable18 |
nickvergessen
approved these changes
Sep 14, 2020
This was referenced Sep 14, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the memory leak fixed here, which was always reproducible, there seems to be another one related to the message list that happens sometimes (and apparently with Chromium, but not with Firefox 🤷). After a lot of time and effort I have not been able to reproduce it reliably nor find why it happens either (it seems to be related to XMLHttpRequests/Axios and
getNewMessages(), but other than that I am still clueless), so I give up for now :-(How to test
Result with this pull request
The size of the new memory snapshot will be around the same value as the previous one
Result without this pull request
The size of the new memory snapshot will be much higher (around 300MB)