Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Fix memory leak in message list #4149

Merged
merged 2 commits into from
Sep 15, 2020
Merged

[stable18] Fix memory leak in message list #4149

merged 2 commits into from
Sep 15, 2020

Commits on Sep 14, 2020

  1. Move network event handlers to their own methods 

    This will be needed to unsubscribe the handlers, as it was not possible
to refer to the arrow functions from other parts of the code.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu @backportbot
    danxuliu authored and backportbot[bot] committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    0893379 View commit details
    Browse the repository at this point in the history

  2. Unsubscribe handlers for network events before component destruction 

    This fixes a memory leak of the message list as well as any other
component that the message list is part of (like the chat view due to
the parent component reference of Vue).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu @backportbot
    danxuliu authored and backportbot[bot] committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    7589a77 View commit details
    Browse the repository at this point in the history