Fix event handler deregistration in TopBar #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if their code is identical two arrow functions are different instances, so the original one was not properly deregistered. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable19 |
nickvergessen
approved these changes
Sep 16, 2020
nickvergessen
deleted the
fix-event-handler-deregistration-in-topbar
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if their code is identical two arrow functions are different instances, so the original one was not properly deregistered.
This caused a memory leak of the chat view or call view if the lobby is enabled while the user is in a conversation (due to the parent component reference of Vue, as that causes the siblings of the
TopBarto be retained too).