Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diverging user status #9411

Merged
merged 2 commits into from
May 2, 2023
Merged

Fix diverging user status #9411

merged 2 commits into from
May 2, 2023

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🚧 Tasks

  • clearAt was invalid type (and only handed in to the event so far)
  • clearAt was missing from docs
  • emit event to update NcAvatar's of the user when we have a new status from the room list

🏁 Checklist

@nickvergessen
fix(user-status): Fix type and missing docs of user status clearAt
2445eb9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(user-status): Emit event when we have a new status so NcAvatar up…
315c024 
…dates

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: conversations 👥 labels May 1, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (27) milestone May 1, 2023
@nickvergessen nickvergessen self-assigned this May 1, 2023
@nickvergessen nickvergessen changed the title Bugfix/8744/fix diverging user status Fix diverging user status May 1, 2023
Antreesy
Antreesy approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on web client

@nickvergessen
Copy link
Member Author

/backport to stable26

@nickvergessen nickvergessen merged commit 12c7d4a into master May 2, 2023
@nickvergessen nickvergessen deleted the bugfix/8744/fix-diverging-user-status branch May 2, 2023 10:42
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 2, 2023
Merged
1 task
vitormattos
vitormattos reviewed May 2, 2023
View reviewed changes
lib/Controller/RoomController.php Show resolved Hide resolved
docs/conversation.md Show resolved Hide resolved
@nickvergessen nickvergessen mentioned this pull request May 2, 2023
Merged
4 tasks
@ShGKme ShGKme mentioned this pull request Jun 22, 2023
Closed
19 tasks
@ShGKme ShGKme mentioned this pull request Jul 27, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormattos vitormattos vitormattos left review comments

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
17.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

User status in topbar and conversation list is not synchronized
3 participants
@nickvergessen @vitormattos @Antreesy