Fix displaying 'Screensharing' button after reject and refactor TopBar controls for 'Raise hand' and 'Screensharing'
#9731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
bug
feature: frontend 🖌️
|
/backport to stable27 |
ShGKme
changed the title
TopBar controls for 'Raise hand' and 'Screensharing'TopBar controls for 'Raise hand' and 'Screensharing'
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/9725/refactor-top-bar
branch
from
fb1a4ac
to
1abc0a4
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
LocalMediaControls=>TopBar/TopBarMediaControls(only usage of component)TopBarMediaControlstoTopBarMenuto reduce amount of duplicated methods🖼️ Screenshots
No visual changes, button doesn't dissapear anymore
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required