Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add eturnal as a second TURN server example #9828

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Documentation: Add eturnal as a second TURN server example #9828

merged 5 commits into from
Jun 28, 2023

Conversation

sando38
Copy link
Contributor

@sando38 sando38 commented Jun 21, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
One document doc/TURN.md Three documents: doc/TURN.md as overview, doc/coturn.md & doc/eturnal.md

🚧 Tasks

  • Review the changes
  • Check if links still work
  • Check if doc/index.md is correct

🏁 Checklist

Message

Please have a look into the changes of the documentation page.
Please also see, if mentioning the prometheus exporter is something to be added into the documentation:
processone/eturnal#41

docs/coturn.md Outdated Show resolved Hide resolved
docs/coturn.md Outdated Show resolved Hide resolved
docs/eturnal.md Outdated Show resolved Hide resolved
docs/eturnal.md Outdated Show resolved Hide resolved
docs/eturnal.md Outdated Show resolved Hide resolved
Also create additonal documents accordingly.

Signed-off-by: sando38 <sandomir@tutanota.com>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise fine and we are ready to go

docs/coturn.md Outdated Show resolved Hide resolved
docs/TURN.md Outdated Show resolved Hide resolved
docs/eturnal.md Outdated Show resolved Hide resolved
docs/eturnal.md Outdated Show resolved Hide resolved
sando38 and others added 4 commits June 28, 2023 12:48
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: sando38 <90323876+sando38@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: sando38 <90323876+sando38@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: sando38 <90323876+sando38@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: sando38 <90323876+sando38@users.noreply.github.com>
@nickvergessen nickvergessen merged commit eff2eac into nextcloud:master Jun 28, 2023
@nickvergessen
Copy link
Member

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@nickvergessen
Copy link
Member

Wrong tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants