Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NewGroupConversation) - fix styles for proper scrolling (again) #9838

Merged
merged 2 commits into from
Jun 22, 2023
Merged

fix(NewGroupConversation) - fix styles for proper scrolling (again) #9838

merged 2 commits into from
Jun 22, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix "New conversation" modal lost it's UX #9831
  • Wrappers were changed, so the main content is only scrollable element inside the modal (header and footer are fixed)
  • In addition, minor refactoring to SetContacts was made, to save cached search results and show them when we clean the search input

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🚧 Tasks

  • Visual check
  • Code review

🏁 Checklist

@Antreesy
replace NcButton with trailing button, cache full search results
9f90954 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
rewrite styles for dialog and inner components
e0a7220 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💜 Next Major (28) milestone Jun 22, 2023
@Antreesy Antreesy self-assigned this Jun 22, 2023
@nickvergessen
Copy link
Member

/backport to stable27

@nickvergessen nickvergessen merged commit d11c9a1 into master Jun 22, 2023
@nickvergessen nickvergessen deleted the fix/9831/fix-new-conversation-dialog-again branch June 22, 2023 12:57
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: conversations 👥 feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

"New conversation" modal lost it's UX
2 participants
@Antreesy @nickvergessen