Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP8's constructor property promotion #9945

Merged

Conversation

shdehnavi
Copy link
Contributor

Summary

This PR is a continuation of the previous PRs regarding refactoring and using PHP8's constructor property promotion:
#9942

I'm splitting the refactoring and the changes into a few PRs to make reviewing the changes easier.

☑️ Resolves

  • Using PHP8's constructor property promotion in the following namespaces:
  • /lib/Settings
  • /lib/Share
  • /lib/Signaling
  • /lib/Status
  • /lib/Vendor

🏁 Checklist

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@nickvergessen nickvergessen added this to the 💜 Next Major (28) milestone Jul 11, 2023
@nickvergessen nickvergessen merged commit e445c0c into nextcloud:master Jul 11, 2023
24 checks passed
@nextcloud nextcloud deleted a comment from github-actions bot May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants