Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace deprecated ILogger with Psr\Log\LoggerInterface #931

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 14, 2024

🧹

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@susnux
Copy link
Contributor

susnux commented Sep 14, 2024

Looks good but please fix the tests:

TypeError: OCA\SuspiciousLogin\Service\LoginClassifier::__construct(): Argument #3 ($logger) must be of type Psr\Log\LoggerInterface, Mock_ILogger_1b76fd3d given, called in /home/runner/actions-runner/_work/suspicious_login/suspicious_login/apps/suspicious_login/tests/Unit/Service/LoginClassifierTest.php on line 64

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc merged commit 0b500ef into master Sep 14, 2024
31 checks passed
@come-nc come-nc deleted the fix/get-rid-of-ilogger branch September 14, 2024 19:04
@st3iny
Copy link
Member

st3iny commented Sep 15, 2024

Thanks, Côme 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants