Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to hide applications as a user #1177

Open
juliushaertl opened this issue Jul 2, 2024 · 5 comments
Open

Ability to hide applications as a user #1177

juliushaertl opened this issue Jul 2, 2024 · 5 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@juliushaertl
Copy link
Member

Leftover from contexts work.

@blizzz Could you document the current logic on what is possible for hiding the applications from the backend side in here so we can have a clear description on what we need to do on the frontend?

@blizzz
Copy link
Member

blizzz commented Jul 12, 2024

So on the backend side we have things in place, but disabled. To turn it on, we simply need:

On the frontend side we need

  • a control for the context owner to set the default display mode.
  • a control per context for a user to set a personal overwrite (e.g. hide or enable)

For the record, we have three modes. The constants are define in Application:

	public const NAV_ENTRY_MODE_HIDDEN = 0;
	public const NAV_ENTRY_MODE_RECIPIENTS = 1;
	public const NAV_ENTRY_MODE_ALL = 2;
  • NAV_ENTRY_MODE_HIDDEN - no nav bar entry
  • NAV_ENTRY_MODE_RECIPIENTS - nav bar entry for share recipients, but not the owner
  • NAV_ENTRY_MODE_ALL - nav bar entry for everybody

Setting the Nav bar entry is possible via following routes:

  • api1#updateShareDisplayMode
  • share#updateDisplayMode

as well as when creating a share, via optional displayMode mode parameter. Default is hidden!

UPDATE 2024-07-26

For we have started to show applications by default, while the nominal default would be to hide them, we also shall change the default to show all and have a repair step to update the existing applications. So, users will not be confused while their applications are not there anymore, also it may be a better, more discoverable setting.

@juliushaertl
Copy link
Member Author

@enjeck As disscussed last week, something to look into after the user/group picker is ready :)

@juliushaertl juliushaertl added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Jul 23, 2024
@blizzz
Copy link
Member

blizzz commented Jul 26, 2024

Added two tasks to #1177 (comment)

@enjeck
Copy link
Contributor

enjeck commented Aug 22, 2024

Setting the Nav bar entry is possible via following routes:

  • api1#updateShareDisplayMode
  • share#updateDisplayMode

So does this mean the owner of the Application can't hide/unhide for themselves? Since it's not a share? @blizzz

@enjeck
Copy link
Contributor

enjeck commented Aug 22, 2024

Setting the Nav bar entry is possible via following routes:

  • api1#updateShareDisplayMode
  • share#updateDisplayMode

So does this mean the owner of the Application can't hide/unhide for themselves? Since it's not a share? @blizzz

Oh, I see that's what NAV_ENTRY_MODE_RECIPIENTS is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
Status: 🏗️ In progress
Development

No branches or pull requests

3 participants