Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure non-nil sessionId #1814

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Ensure non-nil sessionId #1814

wants to merge 3 commits into from

Conversation

SystemKeeper
Copy link
Collaborator

Fixed in this PR:

  • SessionId is an optional, we only rely on the HTTP status code currently
  • For creating a room object, we only rely on the listable capability currently
  • In ChatViewController we just ensure that there's a NCRoom object, not, that it is the correct one

(The last 2 fixes are fixing basically the same thing, but I think we should be explicit here)

@SystemKeeper
Ensure non-null sessionId on join
c878efe 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Ensure room object belongs to room on join
5062096 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Add tests for joining with an empty room object
b43d72c 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper marked this pull request as draft October 7, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Awaiting requested review from Ivansss

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SystemKeeper