Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User status message setting fixes #1824

Merged
merged 7 commits into from
Oct 9, 2024
Merged

User status message setting fixes #1824

merged 7 commits into from
Oct 9, 2024

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Oct 1, 2024

  • Allow to set user status with only an icon or only a message
  • Enable "Clear status message" only when the user has one status already set

Fix #1823

@Ivansss
Allow to set user status message only with an icon or only with a mes…
f339c73 
…sage.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Rename EmojiTextFieldWrapper to SingleEmojiTextFieldWrapper since it …
1baf457 
…only allows to add a single emoji.

Also simplified the logic in UserStatusMessageSwiftUIView.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Show correct error title and message.
34ea244 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Do not force unwrap and set empty icon and messages as defaults.
a767e05 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Just store selectedPredifinedStatusId since clearAt might be variable.
41f4707 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Only enable "Clear status message" button if the user has a status set.
4ab03f3 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Rename variables and avoid force unwrap.
1e746e0 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
SystemKeeper
SystemKeeper approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@SystemKeeper SystemKeeper merged commit 34a8ab4 into master Oct 9, 2024
11 checks passed
@SystemKeeper SystemKeeper deleted the user-status-message-setting-fixes branch October 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@Black-Fox-2022 Black-Fox-2022 Black-Fox-2022 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set status message without emoji
3 participants
@Ivansss @SystemKeeper @Black-Fox-2022