Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sharing calendars / task lists #410

Merged
merged 1 commit into from
May 16, 2019
Merged

Conversation

raimund-schluessler
Copy link
Member

@raimund-schluessler raimund-schluessler commented May 16, 2019

Implements a sharing menu in the calendar list. You can now share task lists with other users. Closes #14.

@skjnldsv I shamelessly copied most of the code from the Contacts app 😇 Works very good as far as I can tell.

Reviews very welcome!

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Member Author

I will merge this now, so that the translations are getting updated. Reviews and testing is still welcome. If issues are found, we can fix them in later PRs.

@raimund-schluessler raimund-schluessler merged commit 5648b2f into master May 16, 2019
@raimund-schluessler raimund-schluessler deleted the sharing branch May 16, 2019 15:50
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found so far! Ui is good and works great!! 👍
Great job!! 😉

@marbetschar
Copy link

@raimund-schluessler not quite sure where to put this, so I shamelessly add it to your pull request here :)

Is it possible to share a public link for a task list? I've seen it's possible in the calendar UI, not sure if I'm missing something in the tasks app. The use case is: I'd love to invite some Non-Nextcloud users to a given task list where they at least can see what's on it using their favourite task-app (Apple Reminders, Web UI, or whatever...)

@raimund-schluessler
Copy link
Member Author

@marbetschar No, this is not possible yet. I think this issue is tracked in #469. As a workaround you could maybe create a calendar in the Calendar app and publicly share the WebCal link from the Calendar app. Tasks should also show up the in their favourite task-app then (but I haven't tested this).

@marbetschar
Copy link

@raimund-schluessler understood. Thanks for clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Share task lists
3 participants