Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX header #937

Merged
merged 7 commits into from
May 10, 2024
Merged

Add SPDX header #937

merged 7 commits into from
May 10, 2024

Conversation

AndyScherzinger
Copy link
Member

and GH action to check on PRs

@AndyScherzinger
chore: Add SPDX header
ad30fba 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Update actions from template repository
98e87c4 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Add SPDX header
9d4acfc 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore(ci): Add reuse check
e88197e 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
docs: Add reuse status badge
e747cd8 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
GretaD
GretaD approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know how to review this, but Im sure it doesnt break anything :)

@AndyScherzinger
Copy link
Member Author

Thanks @GretaD - the only things one could review are:

  • Do the added license key words match the former ones in place
  • Did generated files get a license header instead of being defined in the dep5 file (else the copyrights will vanish once the file gets re-generated)

@AndyScherzinger
fix: change comment type
20dfe54 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member Author

/compile

@nextcloud-command
chore(assets): Recompile assets
6e04fe9 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit 775b007 into master May 10, 2024
24 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/noid/spdx branch May 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees
No one assigned
Labels
3. to review technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyScherzinger @GretaD @nextcloud-command