Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only one close request when closing viewer #3835

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

max-nextcloud
Copy link
Collaborator

πŸ“ Summary

Fixes #3834.

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
Bildschirmfoto vom 2023-02-25 11-08-25 grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@cypress
Copy link

cypress bot commented Feb 25, 2023

Passing run #8744 β†—οΈŽ

0 137 0 0 Flakiness 0

Details:

fix: only one close request when closing viewer
Project: Text Commit: 30e357c043
Status: Passed Duration: 03:14 πŸ’‘
Started: Feb 27, 2023 1:30 PM Ended: Feb 27, 2023 1:33 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Feb 27, 2023
@juliushaertl juliushaertl added this to the Nextcloud 26 milestone Feb 27, 2023
Fixes #3834.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
Copy link
Collaborator Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud merged commit 6cf6e56 into main Feb 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/3834-duplicate-close branch February 27, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate close requests when closing file
3 participants