fix: Provide file id for single file share links #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 flaky tests on run #8790 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| test link marks > link preview > shows a link preview |
Screenshot
|
|
share.spec.js • 1 flaky test
| Test | ||
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Screenshot
|
|
sync.spec.js • 1 flaky test
| Test | ||
|---|---|---|
| Save > saves the actual file and document state |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliushaertl
commented
Feb 28, 2023
max-nextcloud
force-pushed
the
fix/public-share-fileid
branch
2 times, most recently
from
8678fda
to
75f712f
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/public-share-fileid
branch
from
75f712f
to
c13824c
Compare
max-nextcloud
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Härtl jus@bitgrid.net
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)