Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink heading anchor links to 1em, fixes links in headings #3847

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Feb 28, 2023

In readonly mode, the heading anchor links spanned the whole width so far, overlaying potential links in headings.

Fixes: #3822

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working 3. to review labels Feb 28, 2023
@mejo-
Copy link
Member Author

mejo- commented Feb 28, 2023

/backport to stable25

@cypress
Copy link

cypress bot commented Feb 28, 2023

1 flaky tests on run #8782 ↗︎

0 137 0 0 Flakiness 1

Details:

Shrink heading anchor links to `1em`, fixes links in headings
Project: Text Commit: 72424276b8
Status: Passed Duration: 03:14 💡
Started: Feb 28, 2023 4:46 PM Ended: Feb 28, 2023 4:49 PM
Flakiness  cypress/e2e/share.spec.js • 1 flaky test

View Output Video

Test
Open test.md in viewer > Share a file with download disabled shows an error Screenshot

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

In readonly mode, the heading anchor links spanned the whole width so
far, overlaying potential links in headings.

Fixes: #3822

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Member Author

mejo- commented Feb 28, 2023

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit 123985e into main Feb 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/readonly_heading_link branch February 28, 2023 16:50
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@mejo-
Copy link
Member Author

mejo- commented Feb 28, 2023

/backport fc802d0 to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLs in heading do not work in readonly mode
3 participants